Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UsingMessageCorrelationEnricher from MessageRouter #305

Closed
Tracked by #311
stijnmoreels opened this issue Jun 20, 2022 · 1 comment · Fixed by #307
Closed
Tracked by #311

Remove UsingMessageCorrelationEnricher from MessageRouter #305

stijnmoreels opened this issue Jun 20, 2022 · 1 comment · Fixed by #307
Assignees
@pcarmo
Labels
area:correlation All issues related to correlation breaking-change All issues related to code breaking changes. good first issue Good for newcomers
Projects
Roadmap
Milestone
v2.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Previously, we tried to reuse the Serilog's log context enrichment with our message correlation, but that gave unwanted results.

Describe the solution you'd like
Remove the UsingMessageCorrelationEnricher protected method from the MessageRouter in the Arcus.Messaging.Abstractions project.
@stijnmoreels stijnmoreels added the area:correlation All issues related to correlation label Jun 20, 2022
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Jun 20, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Jun 20, 2022
@stijnmoreels stijnmoreels added good first issue Good for newcomers breaking-change All issues related to code breaking changes. labels Jun 20, 2022
@pcarmo pcarmo mentioned this issue Jun 21, 2022
Merged
@stijnmoreels
Copy link
Member Author

Will be assigned to @pcarmo when accepted invite.

@stijnmoreels stijnmoreels mentioned this issue Dec 15, 2023
Open
48 tasks
Roadmap automation moved this from To do to Done Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcarmo pcarmo

Labels
area:correlation All issues related to correlation breaking-change All issues related to code breaking changes. good first issue Good for newcomers
Projects
Roadmap
  
Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

chore: removed UsingMessageCorrelationEnricher protected method from MessageRouter
2 participants
@stijnmoreels @pcarmo