Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Pause to Start in IMessagePumpLifetime #387

Closed
Tracked by #311
stijnmoreels opened this issue Jan 26, 2023 · 2 comments · Fixed by #433
Closed
Tracked by #311

Rename Pause to Start in IMessagePumpLifetime #387

stijnmoreels opened this issue Jan 26, 2023 · 2 comments · Fixed by #433
Assignees
@stijnmoreels
Labels
bug Something isn't working message-pumps All issues related to message pumps
Projects
Roadmap
Milestone
v2.0.0

Comments

@stijnmoreels
Copy link
Member

Describe the bug
We have mistaken the IMessagePumpLifetime interface as we have named a method Pause while it is actually Starting the message pump.

To Reproduce
Steps to reproduce the behavior:
Look for the IMessagePumpLifetime interface.

Expected behavior
Rename the interface correctly.

Additional context
Add any other context about the problem here.

  • v1.4
@stijnmoreels stijnmoreels added bug Something isn't working message-pumps All issues related to message pumps labels Jan 26, 2023
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Jan 26, 2023
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Jan 26, 2023
@stijnmoreels stijnmoreels mentioned this issue Feb 16, 2023
Merged
@stijnmoreels stijnmoreels mentioned this issue Dec 15, 2023
Open
48 tasks
@fgheysels
Copy link
Member

Do we need to go through this, since we've deprecated this interface ?

@stijnmoreels
Copy link
Member Author

Think the interface itself is not deprecated?
https://github.com/arcus-azure/arcus.messaging/blob/main/src/Arcus.Messaging.Pumps.Abstractions/IMessagePumpLifetime.cs

@stijnmoreels stijnmoreels self-assigned this Feb 2, 2024
@stijnmoreels stijnmoreels mentioned this issue Feb 2, 2024
Merged
Roadmap automation moved this from To do to Done Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
bug Something isn't working message-pumps All issues related to message pumps
Projects
Roadmap
  
Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

chore: rename incorrect 'pause' > 'start' in pump lifetime stijnmoreels/arcus.messaging
2 participants
@fgheysels @stijnmoreels