Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AddProvider method overloads with optional secret mutation function #305

Closed
Tracked by #311
stijnmoreels opened this issue Feb 3, 2022 · 0 comments · Fixed by #426
Closed
Tracked by #311

Remove AddProvider method overloads with optional secret mutation function #305

stijnmoreels opened this issue Feb 3, 2022 · 0 comments · Fixed by #426
Assignees
@stijnmoreels
Labels
breaking-change All issues that require to do a breaking chnage good first issue Good for newcomers secret-store All issues related to our secret store
Projects
Roadmap
Milestone
v2.0.0

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Feb 3, 2022 •
edited

Is your feature request related to a problem? Please describe.
When designing the secret store, we first had a single option to mutate the secret name. As this grew, we chose to use an options model to register ISecretProvider implementations, making these methods obsolete.

Describe the solution you'd like
Remove the AddProvider method with a single optional secret mutation function in the SecretStoreBuilder.
@stijnmoreels stijnmoreels added secret-store All issues related to our secret store breaking-change All issues that require to do a breaking chnage labels Feb 3, 2022
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Feb 3, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Feb 3, 2022
@stijnmoreels stijnmoreels changed the title Remove AddProvider method overload with optional secret mutation function Remove AddProvider method overloads with optional secret mutation function Feb 3, 2022
@stijnmoreels stijnmoreels added the good first issue Good for newcomers label Feb 3, 2022
@stijnmoreels stijnmoreels mentioned this issue Dec 15, 2023
Open
48 tasks
@stijnmoreels stijnmoreels self-assigned this Dec 15, 2023
@stijnmoreels stijnmoreels mentioned this issue Dec 18, 2023
Merged
Roadmap automation moved this from To do to Done Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
breaking-change All issues that require to do a breaking chnage good first issue Good for newcomers secret-store All issues related to our secret store
Projects
Roadmap
  
Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

chore: remove deprecated secret store functionality stijnmoreels/arcus.security
1 participant
@stijnmoreels