Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated package Microsoft.Azure.KeyVault.* from Arcus.Security.Providers.AzureKeyVault #311

Closed
Tracked by #311
stijnmoreels opened this issue Feb 10, 2022 · 4 comments · Fixed by #424
Closed
Tracked by #311
Assignees
Labels
azure-key-vault All issues related to Azure Key Vault integration breaking-change All issues that require to do a breaking chnage dependencies Pull requests that update a dependency file
Projects
Milestone

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, we still provide backwards capability to the Microsoft.Azure.KeyVault package but this is now made deprecated.

Describe the solution you'd like
Remove the package so we solely rely on the Azure.Security.KeyVaultSecrets package.

@stijnmoreels stijnmoreels added azure-key-vault All issues related to Azure Key Vault integration dependencies Pull requests that update a dependency file breaking-change All issues that require to do a breaking chnage labels Feb 10, 2022
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Feb 10, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Feb 10, 2022
@stijnmoreels stijnmoreels removed the breaking-change All issues that require to do a breaking chnage label Feb 18, 2022
@stijnmoreels stijnmoreels modified the milestones: v2.0.0, v1.7.0 Feb 18, 2022
@stijnmoreels
Copy link
Member Author

We can make this not a breaking change by implementing (internally) our obsolete IKeyVaultAuthention interface and use TokenCredential instead. This will act as a kind of 'proxy' between obsolete types and will allow us to remove the deprecated Microsoft packages.

@stijnmoreels stijnmoreels added the breaking-change All issues that require to do a breaking chnage label Feb 18, 2022
@stijnmoreels stijnmoreels modified the milestones: v1.7.0, v2.0.0 Feb 18, 2022
@stijnmoreels
Copy link
Member Author

Hmm, this will not work without breaking stuff, bc the IKeyVaultClient is used as a protected overridable method, which means that this method would be removed if we remove the deprecated pacakges...

@stijnmoreels stijnmoreels modified the milestones: v2.0.0, v1.7.0 Mar 11, 2022
@gverstraete
Copy link

When is this planned...?

There are alternatives now for each package we use I think: https://www.nuget.org/packages/Microsoft.Azure.KeyVault/

@stijnmoreels
Copy link
Member Author

stijnmoreels commented Nov 22, 2023

When is this planned...?

There are alternatives now for each package we use I think: https://www.nuget.org/packages/Microsoft.Azure.KeyVault/

They will be deleted in the next major version, after Observability's major version is released.
Feel free to help us prepare for the next Security version here: https://github.com/arcus-azure/arcus.security/milestone/9 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-key-vault All issues related to Azure Key Vault integration breaking-change All issues that require to do a breaking chnage dependencies Pull requests that update a dependency file
Projects
Roadmap
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants