Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the obsolete Azure Key Vault secret store extensions #329

Closed
Tracked by #311
stijnmoreels opened this issue Feb 24, 2022 · 2 comments · Fixed by #424
Closed
Tracked by #311

Remove the obsolete Azure Key Vault secret store extensions #329

stijnmoreels opened this issue Feb 24, 2022 · 2 comments · Fixed by #424
Assignees
Labels
azure-key-vault All issues related to Azure Key Vault integration breaking-change All issues that require to do a breaking chnage good first issue Good for newcomers
Projects
Milestone

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
When designing the Azure Key Vault secret provider for the secret store, there were a lot of changes and migrations: adding options, different authentication mechanisms, new Azure SDK... The older secret store extensions are still in the source.

Describe the solution you'd like
Remove the older obsolete Azure Key Vault secret store extensions.

@stijnmoreels stijnmoreels added good first issue Good for newcomers azure-key-vault All issues related to Azure Key Vault integration breaking-change All issues that require to do a breaking chnage labels Feb 24, 2022
@stijnmoreels stijnmoreels added this to the v2.0.0 milestone Feb 24, 2022
@stijnmoreels stijnmoreels added this to To do in Roadmap via automation Feb 24, 2022
@fgheysels
Copy link
Member

I think we should do this, and not wait any longer with it.
All those obsolete methods (some of them are already obsolete for quite some time - for instance the ones that have the allowCaching parameter are really polluting the intellisense in Visual Studio. It will make things cleaner and easier if they're gone.

@stijnmoreels
Copy link
Member Author

stijnmoreels commented Sep 14, 2022

Yes, was one of the suggestions on observability too, but we didn't go through with it bc that was the only reason why we would have a breaking change.
In this case, we could also include removing the deprecated Azure Key Vault package, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-key-vault All issues related to Azure Key Vault integration breaking-change All issues that require to do a breaking chnage good first issue Good for newcomers
Projects
Roadmap
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants