Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MacOS #2

Open
echelon opened this issue Sep 6, 2019 · 5 comments
Open

Support MacOS #2

echelon opened this issue Sep 6, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@echelon
Copy link

echelon commented Sep 6, 2019

I recently tried building this on my Mac machine. It works fine on Linux, but failed on the Mac with the following build errors:

error[E0609]: no field `0` on type `&mut system::SpeakerSystem`
  --> /Users/bt/.cargo/registry/src/github.com-1ecc6299db9ec823/wavy-0.1.2/src/system.rs:71:14
   |
71 |         self.0.play(&mut || {
   |              ^

error[E0609]: no field `0` on type `&mut system::MicrophoneSystem`
  --> /Users/bt/.cargo/registry/src/github.com-1ecc6299db9ec823/wavy-0.1.2/src/system.rs:96:14
   |
96 |         self.0.record(generator);
   |              ^

The version of Rust I am running,

rustc --version
rustc 1.37.0 (eae3437df 2019-08-13)
cargo --version
cargo 1.37.0 (9edd08916 2019-08-02)

The Mac version is 10.14.6 (18G87)

The published library version is wavy = "0.1.2"

If I get time I'll look into this, but wanted to give you a head's up.

@echelon echelon changed the title Fails to build on MacOS Fails to build on MacOS (wavy = "0.1.2") Sep 6, 2019
@echelon
Copy link
Author

echelon commented Sep 6, 2019

🤦‍♂ I just saw the platform flags in the code and that that Mac support is listed as TODO in the README.

@AldaronLau
Copy link
Member

Yeah, it's a work in progress. Unfortunately, I don't have a way to test this at the moment (since I don't own a Mac, and I can't get my virtual machine to support audio). Although, currently I have a plan to get it done before the end of this year using my university's computers.

@AldaronLau AldaronLau added the enhancement New feature or request label Sep 7, 2019
@echelon
Copy link
Author

echelon commented Sep 10, 2019

Thanks for the super responsive answer! This is already an incredibly valuable crate and I appreciate the functionality already available on Linux.

Depending on the direction my work takes me (I'll eventually need to target iOS), I might wind up in the position to put together a PR.

Thanks!

@AldaronLau AldaronLau changed the title Fails to build on MacOS (wavy = "0.1.2") Support MacOS Jan 14, 2020
@alectrocute
Copy link

I don’t have the time but I will gladly bow to anybody who makes this PR.

@AldaronLau
Copy link
Member

@alectrocute It's getting there, I've been slowly working on it (I have a Mac to test on now) - so, hopefully will be finished in the next few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants