Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Probably Deprecate/Remove Weak::try_recv() #23

Closed
AldaronLau opened this issue Aug 23, 2022 · 0 comments · Fixed by #24
Closed

Should Probably Deprecate/Remove Weak::try_recv() #23

AldaronLau opened this issue Aug 23, 2022 · 0 comments · Fixed by #24

Comments

@AldaronLau
Copy link
Member

Reason:

It's virtually impossible to guarantee that it won't wait indefinitely.

  • Weak is upgraded internally for duration of receive
  • Channel (original) is dropped
  • Waiting on channel with no senders

Weak senders on the other hand:

  • Weak is upgraded internally for duration of send
  • Channel (original) is dropped
  • Send to channel with no receiver(s)
  • Send complete
@AldaronLau AldaronLau mentioned this issue Aug 23, 2022
7 tasks
@AldaronLau AldaronLau linked a pull request Sep 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant