Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android wapm crash at missing /etc/os-release #28

Closed
truboxl opened this issue Sep 23, 2021 · 4 comments · Fixed by #29
Closed

Android wapm crash at missing /etc/os-release #28

truboxl opened this issue Sep 23, 2021 · 4 comments · Fixed by #29
Labels

Comments

@truboxl
Copy link

truboxl commented Sep 23, 2021

Describe the bug
Tried building Android version wapm which uses whoami, getting crashes when running wapm on Android
Not sure how to try experiment patching as I am unfamiliar how cargo works
Deps and all are picked up by cargo automatically

To Reproduce
Unlikely to suggest a very fast way to set up as I am using a complex environment
But it will be a good try to see what happens when /etc/os-release does not exist which is true for Android

Expected behavior
Should not crash

Screenshots
Screenshot_20210923-152546_Termux

Smartphone (please complete the following information):

  • Device: Galaxy A30s
  • OS: Android
  • Browser Chrome? Not relevant
  • Version 11

Additional context
Tried upgrading from whoami 0.5.3 to whoami 1.1.3 in wapm still stuck here

@AldaronLau
Copy link
Member

@truboxl Thanks, for opening the issue! I'll look into fixing it.

@AldaronLau AldaronLau added the bug label Sep 23, 2021
@AldaronLau
Copy link
Member

@truboxl Do you want to test #29? It should fix the issue.

@AldaronLau AldaronLau linked a pull request Sep 25, 2021 that will close this issue
@truboxl
Copy link
Author

truboxl commented Sep 26, 2021

Wow that works! wapm no longer crashes 🤣
Took me quite some time to really understand how to patch using cargo and manifest file
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#working-with-an-unpublished-minor-version
rust-lang/cargo#8690

Screenshot:
Screenshot_20210926-122520_Termux

I think you can close this once landed
I think I will submit PR at wasmer side to use the latest whoami

@AldaronLau
Copy link
Member

@truboxl Just released version 1.1.4 released with the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants