Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps we should bump our MSRV #49

Closed
SteveLauC opened this issue Nov 23, 2022 · 2 comments
Closed

Perhaps we should bump our MSRV #49

SteveLauC opened this issue Nov 23, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@SteveLauC
Copy link
Contributor

I am running into this error:

$ cargo metadata
warning: please specify `--format-version` flag explicitly to avoid compatibility problems
error: failed to download `bumpalo v3.11.1`

Caused by:
  unable to get packages from source

Caused by:
  failed to download replaced source registry `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to parse manifest at `/home/steve/.cargo/registry/src/mirrors.ustc.edu.cn-61ef6e0cd06fb9b8/bumpalo-3.11.1/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  supported edition values are `2015` or `2018`, but `2021` is unknown

$ rg "bumpalo"
Cargo.toml
31:[target.'cfg(target_arch = "wasm32")'.dependencies.bumpalo]

This is because bumpalo bumps their MSRV to 1.56, so perhaps we should also bump our MSRV.

Since whoami won't bump MSRV until a major version update, an alternative approach is to use an older version of bumpalo.

@AldaronLau
Copy link
Member

If you run these commands the error goes away. An alternative would be to remove the rust-toolchain file (which I think would be fine).

Some context: #43

@AldaronLau AldaronLau added the enhancement New feature or request label Nov 24, 2022
@SteveLauC
Copy link
Contributor Author

Thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants