Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Mac OS #6

Closed
AldaronLau opened this issue Jun 3, 2018 · 4 comments
Closed

Test on Mac OS #6

AldaronLau opened this issue Jun 3, 2018 · 4 comments

Comments

@AldaronLau
Copy link
Member

AldaronLau commented Jun 3, 2018

System Support Request

Make sure that the library works on Mac OS.

  • Fix Getting OS Name
  • Fix Getting Computer Name
  • Fix Getting Environment
@cygnus9
Copy link
Contributor

cygnus9 commented Jun 4, 2018

I just had someone test it on a mac, and at least it compiles now. Getting the username also works. Getting the OS or computer name fails at runtime and getting the env simply returns "unknown".

@AldaronLau
Copy link
Member Author

Next time I use a Mac, I'll try and fix it.

@AldaronLau
Copy link
Member Author

Update: I finally got around to testing it on a Mac and I fixed getting the OS name, computer name and environment. whoami 0.4 is out on crates.io with the changes.

@cygnus9
Copy link
Contributor

cygnus9 commented Jan 13, 2019

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants