Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Why IReadRepositoryBase does not include AnyAsync? #180

Closed
devbased opened this issue Dec 8, 2021 · 2 comments
Closed

Question: Why IReadRepositoryBase does not include AnyAsync? #180

devbased opened this issue Dec 8, 2021 · 2 comments
Milestone
6.0

Comments

@devbased
Copy link
Contributor

devbased commented Dec 8, 2021

Seems kind of weird, operations like 'is there anything?' are very popular.
Using count to check existence is not efficient solution. For sure, it could be added to derived interface, but i don't see any point in such a design for this specific method because it's not complex.
@ardalis
Copy link
Owner

ardalis commented Dec 8, 2021

Just hadn't thought of it, I guess. I don't see any reason not to add it. Do you want to submit a PR?

@fiseni fiseni added this to the 6.0 milestone Dec 8, 2021
@fiseni fiseni mentioned this issue Dec 9, 2021
Closed
@devbased
Copy link
Contributor Author

devbased commented Dec 9, 2021

The answer was received. Implementation in #181

@devbased devbased closed this as completed Dec 9, 2021
@gabrielheming gabrielheming mentioned this issue Dec 10, 2021
Merged
@fiseni fiseni mentioned this issue Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
3 participants
@ardalis @fiseni @devbased