Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: XML comments #44

Closed
fiseni opened this issue Sep 11, 2019 · 5 comments
Closed

Question: XML comments #44

fiseni opened this issue Sep 11, 2019 · 5 comments

Comments

@fiseni
Copy link
Contributor

fiseni commented Sep 11, 2019

I'm preparing few packages, and I usually practice generating documentation files for XML comments. I just noticed the PRs in this project are still open, so I'm keen to understand the best way to do this. Most probably there are better approaches, so I look forward to implement better strategies in my projects.

Any comment would be appreciated. Thanks.

@ardalis
Copy link
Owner

ardalis commented Sep 11, 2019

I'm not sure what you're asking. Are you wondering why XML comments aren't used in this project, or ?

@fiseni
Copy link
Contributor Author

fiseni commented Sep 11, 2019

Sorry if I was not clear.
Ardalis.GuardClauses nuget package does not contain the documentation file, therefore intelisense of summary comments for your methods doesnt appear at all (I dont know if you have noticed that).
I just recently started using this package, I spot that, and just quickly created 2 PR for this project. I did it in a way I do for my own packages.
I noticed PRs are open, I was just wondering if there is a better approach , so I can adopt it too :)

@AlexanderJohnston
Copy link

AlexanderJohnston commented Sep 30, 2019

Hello, I echo @fiseni and am curious what you think about fixing the XML comments. The PRs he made look fine to me.

@ardalis
Copy link
Owner

ardalis commented Oct 1, 2019

Sounds good - I'll review the PRs next chance I get and most likely will accept them and publish a new version. Thanks!

@ardalis
Copy link
Owner

ardalis commented Jan 16, 2020

This issue isn't linked to any PRs but I think they've all been merged at this point. Closing but feel free to reopen if necessary.

@ardalis ardalis closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants