Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Guard.Against.Negative ? #50

Closed
elendil-software opened this issue Jan 9, 2020 · 2 comments
Closed

Add Guard.Against.Negative ? #50

elendil-software opened this issue Jan 9, 2020 · 2 comments
Labels
enhancement good first issue help wanted

Comments

@elendil-software
Copy link
Contributor

I wonder if it would make sense to add a Guard.Against.Negative Clause ?

To avoid negative values I could use an uint type. But in some situation I prefer to use int. Especially when the input value come from outside of my projects to avoid the need of cast.

If this suggestion make sense I can do a pull request.
@ardalis
Copy link
Owner

ardalis commented Jan 16, 2020

Sure, sounds like an easy one.

@elendil-software elendil-software mentioned this issue Jan 17, 2020
Merged
ardalis pushed a commit that referenced this issue Jan 17, 2020
@elendil-software @ardalis
Add Guard.Against.Negative (#53)
c614ff4 
#50
@ardalis
Copy link
Owner

ardalis commented Feb 13, 2020

This is done.

@ardalis ardalis closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ardalis @elendil-software