Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[version4] Enable nullable reference types for EF plugin projects and clean up the solution. #32

Closed
fiseni opened this issue Jul 17, 2020 · 0 comments
Closed

[version4] Enable nullable reference types for EF plugin projects and clean up the solution. #32

fiseni opened this issue Jul 17, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@fiseni
Copy link
Collaborator

fiseni commented Jul 17, 2020

Once the PRs are merged into [version4] branch, everything should be cross-checked once again and cleaned up.

  • Enable nullable reference types for EF plugin projects
  • Fix all nullable usages in the solution.
  • Cross-check the tests, namings in particular.
@fiseni fiseni added the help wanted Extra attention is needed label Jul 17, 2020
fiseni added a commit that referenced this issue Jul 18, 2020
@fiseni
Updating nullable reference usages. Fixes #32
709bd11
@fiseni fiseni closed this as completed Jul 18, 2020
ardalis added a commit that referenced this issue Jul 31, 2020
@ardalis @fiseni
Version4 (#36)
28858e2 
* Adding abstract specification and builder with basic functionalities.

* Adding OrderedSpecificationBuilder.

* Add IncludableSpecification builder.

* Adding Select functionality.

* Adding base specification (non-EF ) evaluator.

* Adding caching.

* Cleaning up.

* Updating UnitTests for the base project (Entities, Specs and tests).

* Updating integration tests for the base project (SampleClient, SampleSpec, tests).

* Adding EF plugin project with integration tests.

* WIP: Refactoring the structure of the solution into new data/solution folders.

* Configure integrations tests with localdb, all tests successful. (Docker will fail).

* Updating docker files (two databases, fix coverages), and switch the connection string to docker as default.

* Updating project information for EF plugin package. Remove EntityFramework reference from base package.

* Updating nullable reference usages. Fixes #32

* Adding test for cache key.

* Moving IRepositoryBase to the base project.

* Refactoring the specification builder into a standalone class.

* Renaming "parent" field to more meaningful name (not inner class anymore).

* Cleaning usings; updating names

* Update publish.yml

Co-authored-by: Fati Iseni <fati.iseni@pozitrongroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fiseni