Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body is typed but not checked at runtime #902

Open
GauBen opened this issue Dec 6, 2023 · 3 comments
Open

Request body is typed but not checked at runtime #902

GauBen opened this issue Dec 6, 2023 · 3 comments

Comments

@GauBen
Copy link

GauBen commented Dec 6, 2023

Describe the bug

It seems that the JSON schema given to .route() is purely informational despite what the documentation suggests:

const router = createRouter().route({
  method: 'POST',
  path: '/greetings',
  schemas: {
    request: {
      json: {
        type: 'object',
        properties: {
          name: { type: 'string' },
        },
        required: ['name'],
      },
    },
  },
  handler: async (request) => {
    const { name } = await request.json();
    console.log(typeof name); // Should print "string" according to TypeScript
    return Response.json({ hello: name });
  },
});

Running the following code will not return a server error:

fetch('http://localhost:3000/greetings', {
  method: 'POST',
  headers: {
    'Content-Type': 'application/json',
  },
  body: '{}',
})

To Reproduce Steps to reproduce the behavior:

https://stackblitz.com/edit/stackblitz-starters-zhnkw4?file=index.ts

Run yarn fetch in another terminal :

image

Expected behavior

I'm expecting the request to fail with a 400 Bad Request error

Environment:

  • fets: 0.6.6

Additional context

@m4rvr
Copy link

m4rvr commented Dec 6, 2023

I'm pretty sure it's related to #799 and #896

@ardatan
Copy link
Owner

ardatan commented Dec 6, 2023

I don't think this is related to those issues. It seems TypeBox validation doesn't work with regular JSON schemas.

@m4rvr
Copy link

m4rvr commented Dec 6, 2023

But I'm getting the same issues, even when using the 1:1 JSON schema for params from the docs:
CleanShot 2023-12-06 at 19 24 04
CleanShot 2023-12-06 at 19 24 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants