Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription issue with grpc-example #154

Closed
dan-muller opened this issue Mar 27, 2020 · 5 comments
Closed

Subscription issue with grpc-example #154

dan-muller opened this issue Mar 27, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@dan-muller
Copy link

With a clean pull of the repo and running the example using yarn start I am receiving the error message below when running the query

Query

subscription {
  ExampleSearchMoviesByCast(SearchByCastInput:{
    castName:"Tom Cruise"
  }) {
    name
    year
    rating
    cast
  }
}

Error

/workspace/graphql-mesh/examples/grpc-example/node_modules/grpc-graphql-schema/lib/service_converter.js:114
                    pubsub.publish(`${methodName}-onSubscribe`, payload);
                           ^

TypeError: Cannot read property 'publish' of undefined
    at ClientReadableStream.response.on (/workspace/graphql-mesh/examples/grpc-example/node_modules/grpc-graphql-schema/lib/service_converter.js:114:28)
    at ClientReadableStream.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:269:11)
    at ClientReadableStream.Readable.push (_stream_readable.js:224:10)
    at Object.onReceiveMessage (/workspace/graphql-mesh/examples/grpc-example/node_modules/grpc/src/client_interceptors.js:1263:19)
    at InterceptingListener.recvMessageWithContext (/workspace/graphql-mesh/examples/grpc-example/node_modules/grpc/src/client_interceptors.js:607:19)
    at /workspace/graphql-mesh/examples/grpc-example/node_modules/grpc/src/client_interceptors.js:707:14
error Command failed with exit code 1.
@ardatan ardatan added bug Something isn't working waiting for release labels Mar 28, 2020
@ardatan
Copy link
Owner

ardatan commented Mar 28, 2020

You can try with the canary version;
0.0.16-alpha-af1bf30.33+af1bf30

@dan-muller
Copy link
Author

You can try with the canary version;
0.0.16-alpha-af1bf30.33+af1bf30

Thanks for the update, where can I access the canary releases?

@ardatan
Copy link
Owner

ardatan commented Mar 29, 2020

You can see the CI logs for canary versions but for now could you please try with the version I wrote so we can mark this issue solved :)
Thanks!
0.0.16-alpha-af1bf30.33+af1bf30 <-----

@dan-muller
Copy link
Author

Updating examples/grpc-example/package.json to the alpha worked!

  "dependencies": {
    "@graphql-mesh/cli": "0.0.16-alpha-e413f48.50+e413f48",
    "@graphql-mesh/grpc": "0.0.16-alpha-e413f48.50+e413f48",
    "debug": "4.1.1",
    "google-protobuf": "3.11.4",
    "graphql": "14.6.0",
    "grpc": "1.24.2"
  },

Thanks again for your help!

@ardatan
Copy link
Owner

ardatan commented Apr 2, 2020

Available in 0.0.17 🎉

@ardatan ardatan closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants