Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@graphql-mesh/cross-helpers has unmet peer dependency "react-native@*" #4881

Closed
4 tasks
paales opened this issue Dec 2, 2022 · 2 comments
Closed
4 tasks

Comments

@paales
Copy link

paales commented Dec 2, 2022

Issue workflow progress

Progress of the issue based on the Contributor Workflow

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

GraphQL mesh expects react-native to be installed. Can we move this to optionalDependencies or something?

warning "workspace-aggregator-3164c39f-ca88-4079-a857-5ad31379d5f2 > @graphcommerce/cli > @graphql-mesh/cli > @graphql-mesh/cross-helpers > react-native-fs@2.20.0" has unmet peer dependency "react-native@*"

To Reproduce
Steps to reproduce the behavior:

Install graphql-mesh

Expected behavior

No unmet peer dependency errors.

Environment:

  • OS:
  • @graphql-mesh/...:
  • NodeJS:

Additional context

@mnlbox
Copy link

mnlbox commented Jul 21, 2023

@ardatan any update on this?

@ardatan
Copy link
Owner

ardatan commented Sep 25, 2023

Solved in the latest release!

@ardatan ardatan closed this as completed Sep 25, 2023
@theguild-bot theguild-bot mentioned this issue Sep 28, 2023
This was referenced Apr 30, 2024
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants