New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format check in CI #6765

Open

enisdenjo opened this issue Mar 28, 2024 · 3 comments

Collaborator

enisdenjo commented Mar 28, 2024

#6748 was merged with a bunch of formatting issues (that I fixed later). Add a format check to the CI to prevent this.

Owner

ardatan commented Mar 28, 2024

This needs to be fixed then

graphql-mesh/.github/workflows/tests.yml

Line 17 in 708c184

jobs:

Collaborator Author

enisdenjo commented Mar 29, 2024

hmm the lint run did exit with 1, but the ci passed still https://github.com/ardatan/graphql-mesh/actions/runs/8471226281/job/23211261474

Collaborator Author

enisdenjo commented Mar 29, 2024

I reckon it's because of the continue-on-error in The Guild's lint workflow https://github.com/the-guild-org/shared-config/blob/0300346178e425c37c6f028959634499282d5700/.github/workflows/lint.yml#L55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment