Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transports should have dispose function #6836

Open
enisdenjo opened this issue Apr 12, 2024 · 0 comments
Open

Transports should have dispose function #6836

enisdenjo opened this issue Apr 12, 2024 · 0 comments
Assignees

Comments

@enisdenjo
Copy link
Collaborator

Some transports have long-living connections, like mysql and neo4j. Currently we depend on the pubsub destroy event to close the connections, but this doesn't work because:

  • Not clear to the user
  • Prone to errors because user might just not provide it
  • pubsub is used for subscriptions, not disposal

Instead of relying on the pubsub, each transport should implement a dispose function that closes any relevant connections during shutdown.

@enisdenjo enisdenjo self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant