Functional Schema Directives don't execute in LTR order as Legacy SchemaVisitor or directive resolvers

[suparngp]

The behavior of schema transform based directive and SchemaVisitor based directives seems to be different in regards to their execution order if you specify multiple directives. For example

directive @map on FIELD_DEFINITION
directive @filter on FIELD_DEFINITION
# usage
type MyType {
    list1: [String!]! @map @filter
    list2: [String!]! @filter @map
}
const schema = makeExecutableSchema({
  schemaTransforms: [mapDirective, filterDirective] // vs [filterDirective, mapDirective]
});

In this case, map always executed before filter regardless of placement on the field. I believe that schemaTransforms being an array introduces this order.

Are these two apis (SchemaVisitor vs functional) supposed to be interchangeable or complementary, especially since schemaDirectives is marked as Legacy?

Is there an example where I can see how to rewrite a directive with the new API while preserving the order?

[yaacovCR]

You would combine whatever directives you need to be in LTR order (or any other order) into a single transformation function and pass multiple directive names as needed. This is essentially how directiveResolvers are currently implemented......

[yaacovCR]

This should be better documented...

[suparngp]

If I understand correctly, I'd have to create a new directive / transform for every combination of these directives. I cannot reuse them by declaring them in the schema in different orders like directiveResolvers? Or may be create a new directive which accepts a list of other directive names (or transform names per say) and applies them in order? While either approaches don't feel intuitive, they do solve my use cases. It would make sense to clarify in the docs which approach to create directives should be preferred because at the moment, it seems that both schemaDirectives and directiveResolvers are considered legacy vs the mapSchema based functional api but there is a clear gap in the out of the box functionality in the new vs old apis.

For now, I created a new function attachSchemaTransforms similar to attachDirectiveResolvers which takes a map of transforms and their names and applies them in order after calling makeExecutableSchema.

Feel free to close this issue since my original question is clarified and there are approaches to solve these use cases.

[yaacovCR]

Closing, thanks so much!