Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegateRequest not waiting for Remote Executor to resolve #1836

Closed
cajames opened this issue Jul 28, 2020 · 0 comments · Fixed by #1837
Closed

delegateRequest not waiting for Remote Executor to resolve #1836

cajames opened this issue Jul 28, 2020 · 0 comments · Fixed by #1837

Comments

@cajames
Copy link
Contributor

cajames commented Jul 28, 2020

When using a remote executor, in the Delegate module, the delegateRequest function fails to wait for promise resolution. This is caused by this line:

if (executionResult instanceof Promise) {
return executionResult.then(originalResult => transformer.transformResult(originalResult));
}
return transformer.transformResult(executionResult);

executionResult instanceof Promise returns false in Node 12.8.0. This issue has been faced elsewhere.

This causes all results from a remote schema to be null, and could lead to unhandled promise rejections.

@cajames cajames changed the title DelegateToSchema not waiting for Remote Executor to resolve delegateRequest not waiting for Remote Executor to resolve Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant