Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias/rename "mapKeysFn/mapResultsFn" as "mapKeys/mapResults" #1863

Closed
gmac opened this issue Jul 31, 2020 · 2 comments
Closed

Alias/rename "mapKeysFn/mapResultsFn" as "mapKeys/mapResults" #1863

gmac opened this issue Jul 31, 2020 · 2 comments

Comments

@gmac
Copy link
Contributor

gmac commented Jul 31, 2020 •
edited

Nit: the new mapKeysFn and mapResultsFn mapping methods (batch delegation) are pretty jarring with the Fn suffix – it's unlike anything else in the Tools API. I'd suggest renaming them or at least aliasing them to just mapKeys and mapResults, then documenting those names as the official API.

Or, feel free to close and disregard.
@yaacovCR
Copy link
Collaborator

I know! Fn suffix is Dataloader format which is used in batch delegation, and then batch delegation should match the stitching arguments...

I think it makes sense to remove the suffix everywhere, and have the clash be elsewhere, but traveling today, would definitely accept PR, not a breaking change as this has not been released yet

@yaacovCR yaacovCR mentioned this issue Aug 2, 2020
Merged
@yaacovCR yaacovCR added the waiting-for-release Fixed/resolved, and waiting for the next stable release label Aug 2, 2020
@gmac
Copy link
Contributor Author

gmac commented Aug 14, 2020

Fixed. Official field names documented in #1910.

@gmac gmac closed this as completed Aug 14, 2020
@yaacovCR yaacovCR removed the waiting-for-release Fixed/resolved, and waiting for the next stable release label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmac @yaacovCR