Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for generateSchema have too much code repetition #26

Closed
helfer opened this issue Apr 13, 2016 · 1 comment
Closed

Tests for generateSchema have too much code repetition #26

helfer opened this issue Apr 13, 2016 · 1 comment

Comments

@helfer
Copy link
Contributor

helfer commented Apr 13, 2016

It would make sense to rewrite the tests in this way:

  • Define a complete shorthand once for all tests
  • Define some resolve functions once for all tests
  • Write a helper function that given the expected result generates and runs query and checks the result

(PS: I probably won't do this any time soon, but PRs very much appreciated)

@helfer
Copy link
Contributor Author

helfer commented May 4, 2016

Closing this since there's more important work to do. The tests work and they probably won't change. If we revisit the file, then we can refactor it when we get to it.

@helfer helfer closed this as completed May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant