Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attachLoadersToContext can only throw error at query execution time, not at call-time #28

Closed
helfer opened this issue Apr 13, 2016 · 1 comment

Comments

@helfer
Copy link
Contributor

helfer commented Apr 13, 2016

This is because loaders get attached for every query in the root resolve function, and we don't know whether the context is an object until we run a query.

We can fix this if we control the server as well, because then we can ensure that the context is an object, and we could throw an internal server error if the context provided is not an object. That's a good argument for using all our tools in combination.

@helfer
Copy link
Contributor Author

helfer commented May 4, 2016

Closing this for now, we can reopen if it ever becomes a concern again.

@helfer helfer closed this as completed May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant