Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requireResolversForArgs incorrectly labelled as missing with subscription args #3571

Open
Tracked by #5201 ...
Darkbladecr opened this issue Sep 22, 2021 · 1 comment
Open
Tracked by #5201 ...
Labels
stage/1-reproduction A reproduction exists

Comments

@Darkbladecr
Copy link

Darkbladecr commented Sep 22, 2021

Describe the bug
When arguments are added to the subscription type on the graphQL schema the requireResolversForArgs is incorrectly erroring.

type Subscription {
  numberIncremented(id: Int): Int
}

Resolver missing for "Subscription.numberIncremented".

To Reproduce
Example forked from official Apollo-server example:
https://codesandbox.io/s/pensive-joliot-brxcj?file=/index.js

Expected behavior
If arguments taken off the subscription type in the schema, everything works fine.

  • OS:
  • @graphql-tools/...: 7.1.5
@Urigo Urigo added the stage/1-reproduction A reproduction exists label Sep 23, 2021
@Urigo
Copy link
Collaborator

Urigo commented Sep 23, 2021

Hi @Darkbladecr and thank you for the report

Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow.

It seems already got into stage 1 thanks to your reproduction! Thank you for that!

Now in order to advance to stage 2 we'll need a failing test, would be great if someone could help progress the issues through the stages.

Thank you and sorry that this comment is not a complete solution (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/1-reproduction A reproduction exists
Projects
None yet
Development

No branches or pull requests

2 participants