Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make graphql a peerDependency #50

Closed
ntharim opened this issue May 13, 2016 · 1 comment
Closed

Make graphql a peerDependency #50

ntharim opened this issue May 13, 2016 · 1 comment

Comments

@ntharim
Copy link
Contributor

ntharim commented May 13, 2016

What do you think about making graphql a peer dependency to be in line with graphql-relay, express-graphql and graphiql?

This will make it easier to upgrade graphql without having to wait for graphql-tools to update its dependencies.
@helfer
Copy link
Contributor

helfer commented May 13, 2016

Yeah, we could definitely do that. The thing I'm worried about is that graphql-tools - in very few places - relies on internals of graphql which may cause it to break when you update. I don't think it would make a difference though.

Do you want to make a PR?

@ntharim ntharim mentioned this issue May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ntharim @helfer