Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocks not executed for some non-nullable types #56

Closed
mpowaga opened this issue May 20, 2016 · 2 comments
Closed

Mocks not executed for some non-nullable types #56

mpowaga opened this issue May 20, 2016 · 2 comments

Comments

@mpowaga
Copy link
Contributor

mpowaga commented May 20, 2016

As discussed on Slack I created a repo with list of unexpected results here. Seems that only non-nullable arrays are not mocked correctly.
@helfer
Copy link
Contributor

helfer commented May 20, 2016

Thanks, I'll look into this soon! Can you provide the code for your mocks as well?

@mpowaga
Copy link
Contributor Author

mpowaga commented May 21, 2016

I linked to markdown file only but all my code is in repo as well.

@helfer helfer closed this as completed in 3c76cf9 May 21, 2016
helfer added a commit that referenced this issue May 21, 2016
@helfer
Merge pull request #59 from mpowaga/fix-mock
24c8abb 
Use nullable type. Fixes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpowaga @helfer