Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an npm package to get around npm / graphql-js issues #9

Closed
helfer opened this issue Apr 2, 2016 · 1 comment
Closed

Need an npm package to get around npm / graphql-js issues #9

helfer opened this issue Apr 2, 2016 · 1 comment

Comments

@helfer
Copy link
Contributor

helfer commented Apr 2, 2016

Using different versions of graphql-js for generating the schema and executing queries doesn't work, because graphql-js uses instanceof to check if a schema is a graphql schema.

When installing from github, it seems that npm installs multiple copies of the apollo-server package, even when they are the same version. This leads to the issue above showing up all the time. Creating an experimental npm package should do the trick, but we'd have to do it for apollo-server and our fork of graphql-js (and express-graphql, if we want to use that as well). Hopefully a new npm version of graphql-js will solve this problem soon, because it's quite a hassle.

@helfer
Copy link
Contributor Author

helfer commented Apr 6, 2016

new version of graphql-js is out, so this isn't as much of an issue any more.

@helfer helfer closed this as completed Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant