Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Want to add features #56

Closed
jaspreetsidhu3 opened this issue Oct 18, 2020 · 1 comment · Fixed by #57
Closed

Want to add features #56

jaspreetsidhu3 opened this issue Oct 18, 2020 · 1 comment · Fixed by #57
Assignees
@jaspreetsidhu3

Comments

@jaspreetsidhu3
Copy link
Contributor

In activity_main.xml

  • There is no hint in AutoCompleteTextView

In NavigationView menu items on click its showing toast "Not implemented yet"
The items where I can work

  • Setting
  • About us
  • Share
  • Privacy Policy

Expected behaviour

  • In autocompletetextview I can add hint as "Add Location" or whatever you suggest
  • NavigationView items onClick I want your suggestion So that I can work according to it

Would you like to work on the issue?

Yeah, why not😇
@ardovic
Copy link
Owner

ardovic commented Oct 18, 2020

Great work on yor previous contribution! Sure, you're welcome to create new screens (Setting, Share - rasiest, About us - where you can either hardcode list of contributers, or use Github API to load list of contributers - maybe after).

@ardovic ardovic linked a pull request Oct 18, 2020 that will close this issue
Improvements #57
Merged
3 tasks
@ardovic ardovic closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaspreetsidhu3 jaspreetsidhu3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements jaspreetsidhu3/Open-Source-Android-Weather-App
2 participants
@ardovic @jaspreetsidhu3