New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-1918: PST composite #621
Conversation
Visit the preview URL for this PR (updated for commit a8e6865): https://ardrive-web--pr621-pe-1918-asn7k3fb.web.app (expires Fri, 02 Sep 2022 21:36:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* self review checkpoint *
…ers and the composite PE-1918
Only missing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* self review checkpoint *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost finishing! Reviewed all implementations. Just need to review the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished review! Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a small comment about changing the while
approach with for
. But it's good to go! thanks for addressing all of my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one single comment. Imma apply the change and manually test the PR
247580d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 👍🏽
Changes
ArweaveAddress
,Winston
, andTransactionID
from CORE into DartContractReader
interfaceRedstoneContractReader
VertoContractReader
SmartweaveContractReader
ContractOracle
interfaceclassArDriveContractOracle
(the composite class; implementsContractOracle
)CommunityOracle
interfaceclassContractOracle
(e.i. the composite class) to make high-level computationsCommunityOracle
to thePSTService
TODO
Make theweightedRandom
method testable