Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.ini file should be created in the user folder #733

Closed
umbynos opened this issue Nov 24, 2022 · 1 comment · Fixed by #761
Closed

config.ini file should be created in the user folder #733

umbynos opened this issue Nov 24, 2022 · 1 comment · Fixed by #761
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@umbynos
Copy link
Contributor

umbynos commented Nov 24, 2022

Put the configuration file (config.ini) file in another directory, outside the bundle/install dir, probably the best place would be ~/.arduino-create/ (on macOS and Linux), for Windows AppData/Roaming. Obviously, the agent should do this based on the OS it is currently running on. All the logic should be already present since it's the folder created for the tools installation. Check if the folder is deleted after the update or the uninstallation.
The agent should:

  1. check if the config file is present in the new destination (if present, done)
  2. check if the config file is present in the old location (alongside the binary), for possible customizations, and copy it to the new destination
  3. else create it in the new destination from the default values inside the binary
@umbynos umbynos added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Nov 24, 2022
@umbynos umbynos added this to the MacOS Ventura Support milestone Nov 24, 2022
@umbynos umbynos self-assigned this Nov 24, 2022
@umbynos
Copy link
Contributor Author

umbynos commented Dec 13, 2022

The config.ini file handling should also be removed from the CI,
The same change should also apply to the additional config file. Documentation should be modified accordingly

@umbynos umbynos linked a pull request Dec 13, 2022 that will close this issue
2 tasks
@umbynos umbynos linked a pull request Feb 10, 2023 that will close this issue
2 tasks
@umbynos umbynos closed this as completed Feb 10, 2023
@per1234 per1234 added the conclusion: resolved Issue was resolved label Feb 11, 2023
@umbynos umbynos removed a link to a pull request Feb 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants