Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary files are not cleaned up #158

Closed
3 tasks done
per1234 opened this issue Jan 2, 2023 · 1 comment · Fixed by #159 or #171
Closed
3 tasks done

Temporary files are not cleaned up #158

per1234 opened this issue Jan 2, 2023 · 1 comment · Fixed by #159 or #171
Assignees
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Jan 2, 2023

Describe the problem

Arduino Firmware Uploader creates some temporary folders:

  • Name format: 55770067919477794103602099745
  • Name: fwuploader

These persist even after the process completes.

The class of folder first on that list accumulates over time, which may eventually cause a performance impact.

To reproduce

  1. Take note of the contents of your temporary folder.
    • Windows:
      C:\Users\<user name>\AppData\Local\Temp
      
    • Linux:
      /tmp
      
    • macOS
      $TMPDIR
      
  2. Run the following command:
    arduino-fwuploader firmware list
    
  3. Examine the contents of your temporary folder.

🐛 An additional 55770067919477794103602099745 folder is present.
🐛 The fwuploader folder is still present.

Expected behavior

Temporary files are cleaned up on exit.

Arduino Language Server version

2b1ab09

Operating system

  • Windows
  • Linux
  • macOS

Operating system version

  • Windows 11
  • Ubuntu 22.04
  • macOS Ventura

Additional context

Some operating systems may eventually do a clean-up on the temporary folder, but this is not guaranteed. It is better for the application to take care of clean up of any temporary files once they are no longer needed.


Additional reports:


Related:

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 2, 2023
@MatteoPologruto MatteoPologruto linked a pull request Jan 9, 2023 that will close this issue
@gashtaan

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
3 participants