Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Confirm Exit not working #114

Closed
djoel1 opened this issue Oct 27, 2019 · 3 comments
Closed

Confirm Exit not working #114

djoel1 opened this issue Oct 27, 2019 · 3 comments
Assignees
@kittaakos
Labels
type: imperfection Something isn't working
Milestone
v0.0.3

Comments

@djoel1
Copy link

djoel1 commented Oct 27, 2019

Preference Application ConfirmExit tried always and ifRequired
Push exit, application closes without asking anything

Expected behavior
Likley show a message box asking you if you want to exit

Desktop (please complete the following information):

  • OS: Windows 7
    IDE 0.0.2
@djoel1 djoel1 added the type: imperfection Something isn't working label Oct 27, 2019
@mastrolinux
Copy link
Contributor

This one was a bug in Theia https://github.com/eclipse-theia/theia/blob/aff11bec2a0424a63e506613d9e23f2e6bdd1d42/packages/core/src/browser/window/default-window-service.ts

Will be fixed when we will rebase to the new master.

@kittaakos kittaakos self-assigned this Nov 5, 2019
@kittaakos
Copy link
Contributor

I have updated to next (0.13.0-next.f2b35569) Theia; I can confirm it works now on macOS. I will re-verify this item before roll out our next release.

@mastrolinux mastrolinux added this to the v0.0.3 milestone Nov 26, 2019
@kittaakos
Copy link
Contributor

Was fixed in 0.0.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kittaakos kittaakos

Labels
type: imperfection Something isn't working
Projects
None yet
Milestone
v0.0.3
Development

No branches or pull requests
3 participants
@mastrolinux @kittaakos @djoel1