[3.x] BlockRenderer does not render nested blocks in order of position

[mikerockett]

Description

When fetching root blocks, the default behaviour is to order by position. However, the same cannot be said for nested blocks, as the query simply fetches by parent_id without any ordering.

Steps to reproduce

1. Create a block that uses a block editor that references any block type.
2. Add an instance of that block to a module, such as a page.
3. Create a template for both blocks, and use renderChildren(name) in the root block template.
4. Add some child blocks and re-order them. The order will not be as intended.

Expected result

Nested blocks at all levels should rendered be in the order defined.

Actual result

Nested blocks are ordered as per the database’s default ordering.

Steps to correct

In BlockRenderer, exchange the $childBlocks assignment in getNestedBlocksForBlock to:

$childBlocks = A17Block::whereParentId($block->id)->orderBy(
    config('twill.blocks_table', 'twill_blocks') . '.position',
    'asc'
)->get();

(May I open a PR against 3.x?)

Versions

Twill version: 3.0.0-beta2
Laravel version: 9.x
PHP version: 8.1
Database engine: Postgres 14

[mikerockett]

Have gone ahead and opened a PR targetting 3.x