Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in documentation #1804

Closed
jhcarl0814 opened this issue Sep 8, 2022 · 0 comments
Closed

typo in documentation #1804

jhcarl0814 opened this issue Sep 8, 2022 · 0 comments
Labels
type: documentation This issue means we need to improve docs

Comments

@jhcarl0814
Copy link

jhcarl0814 commented Sep 8, 2022

Description

Steps to reproduce

visit https://twill.io/docs/getting-started/configuration.html

should change from:
If you do not intend to access files uploaded to S3 directly, set the FILE_LIBRARY_ACL variable or acl configuration option to public-read.
to:
If you do not intend to access files uploaded to S3 directly, set the FILE_LIBRARY_ACL variable or acl configuration option to private.

from:
You can change the default service using the FILE_LIBRARY_IMAGE_SERVICE environment variable or the file_library.image_service configuration option.
to:
You can change the default service using the FILE_LIBRARY_FILE_SERVICE environment variable or the file_library.file_service configuration option.


visit https://twill.io/docs/crud-modules/migrations.html

should change from:
will add the following inscructions to your migration file
to:
will add the following instructions to your migration file


visit https://twill.io/docs/crud-modules/models.html

should change from:
astronomic/laravel-translatable
to:
astrotomic/laravel-translatable


visit https://twill.io/docs/media-library/image-rendering-service.html

should change from:
$crop_params will be an array with the following keys: crop_x, crop_y, crop_w and crop_y.
to:
$crop_params will be an array with the following keys: crop_x, crop_y, crop_w and crop_h.

Expected result

Actual result

Versions

@haringsrob haringsrob added the type: documentation This issue means we need to improve docs label Oct 17, 2022
ifox added a commit that referenced this issue Feb 10, 2024
ifox added a commit that referenced this issue Feb 10, 2024
ifox added a commit that referenced this issue Feb 10, 2024
ifox added a commit that referenced this issue Feb 10, 2024
@ifox ifox closed this as completed Feb 10, 2024
AidasK pushed a commit to AidasK/twill that referenced this issue May 4, 2024
AidasK pushed a commit to AidasK/twill that referenced this issue May 4, 2024
AidasK pushed a commit to AidasK/twill that referenced this issue May 4, 2024
AidasK pushed a commit to AidasK/twill that referenced this issue May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation This issue means we need to improve docs
Projects
None yet
Development

No branches or pull requests

3 participants