Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS issue #436

Closed
decaffeinatedio opened this issue Jul 18, 2022 · 3 comments
Closed

XSS issue #436

decaffeinatedio opened this issue Jul 18, 2022 · 3 comments
Assignees
@aanon4

Comments

@decaffeinatedio
Copy link

decaffeinatedio commented Jul 18, 2022 •
edited by dman776

Thanks for creating this great project!

[details removed]
@aanon4 aanon4 self-assigned this Jul 18, 2022
@aanon4 aanon4 mentioned this issue Jul 18, 2022
Merged
@aanon4
Copy link
Contributor

aanon4 commented Jul 18, 2022

@decaffeinatedio I can't add you as a reviewer I'm afraid, but please take a look.

@decaffeinatedio
Copy link
Author

Would it be sufficient to prevent < and > characters being used as part of a service name?

In my experience that should do it outside of some very unusual edge cases. I'll take a look at the PR now!

@decaffeinatedio
Copy link
Author

Resolved by #437

@aredn aredn deleted a comment from aanon4 Jul 20, 2022
@dman776 dman776 changed the title XSS is possible via the "service name" form field XSS issue Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aanon4 aanon4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aanon4 @decaffeinatedio