Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unit tests #103

Open
aregtech opened this issue Jan 2, 2023 · 6 comments
Open

Extend unit tests #103

aregtech opened this issue Jan 2, 2023 · 6 comments
Labels
C++ challenge enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed improvement unit test

Comments

@aregtech
Copy link
Owner

aregtech commented Jan 2, 2023

Problem
The demonstration of features are in the example folder of AREG SDK. But still there are many objects and many methods that are never tested. In order to test, there is a need to increase amount of unit tests.

Actions
The unit tests are integrated and should be implemented in the tests/units. Each .cpp file should contain one test name. The tests are added in the CMakeFiles.txt by calling addTest() method, which automatically includes the tests in the compilation. The testing module is the AREG engine / framework.

Note
This ticket cannot be assigned to one person since the topic of unit tests is huge.
Please inform for which object / topic you want to create unit test and I'll create a separate ticket and branch, and assign to you.

@aregtech aregtech added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers C++ unit test challenge improvement labels Jan 2, 2023
@aregtech aregtech assigned aregtech and unassigned aregtech Jan 2, 2023
@harshit496
Copy link
Contributor

@aregtech I am interested in working on this issue. Could you assign it to me?

@aregtech
Copy link
Owner Author

@harshit496, thank you very much.
Since this topic is very huge, i suggest to select 1-3 classes that you'd like to test, so that I'll create a separate issue and you can work on that.

@harshit496
Copy link
Contributor

harshit496 commented Feb 13, 2023

How about if I write tests for the all the classes in appbase dir?

@aregtech
Copy link
Owner Author

@harshit496 ,
I would suggest classes in base. Classes like string or containers, DateTime, etc.
In appbase the main class is Application, which most probably should be mocked to be able to test. And the Console class I'll soon move out of areg framework.

@harshit496
Copy link
Contributor

Sounds good. I can take the three classes you mentioned then

  • Containers
  • DateTime
  • Strings

@aregtech
Copy link
Owner Author

OK. Let's start with strings. They are big enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ challenge enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed improvement unit test
Projects
Status: No status
Development

No branches or pull requests

2 participants