Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installing docset from file command #79

Closed
wants to merge 1 commit into from

Conversation

carltonf
Copy link

@carltonf carltonf commented May 1, 2015

  • Useful for slow connections. Also downloading from Web page seems to pick the
    optimal mirror for the user.

* Useful for slow connections. Also downloading from Web page seems to pick the
  optimal mirror for the user.
kidd pushed a commit that referenced this pull request May 8, 2015
@kidd
Copy link
Member

kidd commented May 11, 2015

Hi,
sorry for the late response. The code is indeed correct, but we have a larger PR (kindof) ready that applies the same change making this function interactive (I also changed the name to match yours).

As it'd create conflicts with the other one, I'll close this (when we merge the other one), but the functionality will be there anyway.

Thanks for contributing anyway!

EDIT: the commit: 7d95f3b

@carltonf
Copy link
Author

It's OK. Glad to see this feature is added. Thanks.

@kidd kidd closed this May 12, 2015
@carltonf carltonf deleted the install-from-local branch May 12, 2015 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants