Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "make prod" #12

Closed
xbrles opened this issue Apr 9, 2019 · 11 comments
Closed

Issue with "make prod" #12

xbrles opened this issue Apr 9, 2019 · 11 comments

Comments

@xbrles
Copy link

xbrles commented Apr 9, 2019

Dear all,

We have a problem at the moment we run "make prod", the process never finishes and there are no messages.

We're using Windows 10 and the last version available of npm (6.9.0).

Executing "npm run test" bring some errors:

image

image

Also attached the LOG of the execution of the "npm run test".

2019-04-09T17_03_06_247Z-debug.log

Any support is very much appreciated.

Thanks in advance for your help!


Javier Mora
XBRL Spain
info@xbrl.es

paulwarren-wk referenced this issue in paulwarren-wk/ixbrl-viewer Apr 18, 2019
This fixes the problem with tests failing in locales where 1st Jan is
not on UTC (i.e. the UK) as mentioned in #12.
@paulwarren-wk
Copy link
Contributor

bc3aa0a should hopefully fix the issue with the tests.

I'm not sure what the issue is with make prod. Does "make dev" work any better?

@xbrles
Copy link
Author

xbrles commented Apr 20, 2019

Hi Paul,

Thanks for your help! Let me explain you step by step what I'm doing.

STEP 1. After installing npm, I've run "npm install" with this result:

image

Please, let me know if I need to fix something related to the warnings.

STEP 2. After your last commit, I've successfully run the javascript unit tests with "npm run test"

image

STEP 3. Both commands: "make prod" and "make dev" have the same result, the blinking underscore symbol as the process never finishes and no error messages related.

image

Any ideas of how can I solve this issue?

Thanks in advance for your help!


Javier Mora
XBRL Spain
info@xbrl.es

@paulwarren-wk
Copy link
Contributor

Can you try doing:

cd iXBRLViewerPlugin\viewer
npx webpack --config webpack.dev.js --optimize-minimize

@xbrles
Copy link
Author

xbrles commented Apr 21, 2019

Hi Paul,

This is the result of running these commands.

image

It looks like the process finishes successfully and the "ixbrlviewer.dev.js" file has been created in the "iXBRLViewerPlugin/viewer/dist" directory.

image

Is this the correct file? The name of the JavaScript file is slightly different from the one in the instructions: "ixbrlviewer.js" vs "ixbrlviewer.dev.js".

Thanks for your help!


Javier Mora
XBRL Spain
info@xbrl.es

@paulwarren-wk
Copy link
Contributor

Glad it's working. The two files are interchangeable - the .dev version just contains extra information for debugging. If you want the normal version, just use:

npx webpack --config webpack.prod.js --optimize-minimize

@paulwarren-wk
Copy link
Contributor

paulwarren-wk commented Apr 21, 2019

There's a fix for this issue here:

https://github.com/paulwarren-wk/ixbrl-viewer/tree/issue-12-build-fixes

If you've not already got the Arelle plugin working, note the updated instructions in the above.

@xbrles
Copy link
Author

xbrles commented Apr 21, 2019

Thank you, Paul.

The command:

npx webpack --config webpack.prod.js --optimize-minimize

seems to work OK, even I get some warnings

image

Now I've both JavaScript files ("ixbrlviewer.js" and "ixbrlviewer.dev.js") on the "iXBRLViewerPlugin/viewer/dist" directory.

image

@xbrles
Copy link
Author

xbrles commented Apr 21, 2019

Paul,

I confirm that I have been able to install successfully the iXBRL viewer plugin on Arelle:

image

Thanks for your support!


Javier Mora
XBRL Spain
info@xbrl.es

@xbrles
Copy link
Author

xbrles commented Apr 21, 2019

Paul,

Everything is working but the process of loading the iXBRL instance document, after saving it with the Arelle iXBRL Viewer plugin, and trying to open it with Google Chrome (version 73.0.3683.103), it gets stuck on this screen:

image

Please, find attached the original iXBRL (Alexandria-2018-Statements.html) and the one saved by the Arelle iXBRL Viewer plugin (Alexandria-2018-Statements-ixbrlviewer.html).

Alexandria-2018-Statements.zip

Thanks for your support!


Javier Mora
XBRL Spain
info@xbrl.es

@paulwarren-wk
Copy link
Contributor

I think your -ixbrlviewer.html file was generated by an older version of the Arelle plugin than your ixbrlviewer.js file is expecting. Could you try regenerating the file, and seeing if that fixes it? If not, please can you report what's on the Javascript console, and attach a copy of ixbrlviewer.js?

@xbrles
Copy link
Author

xbrles commented Apr 22, 2019

Thank you, Paul.

Indeed you're right, I was using the v0.1 (2019-03-22) of the Arelle iXBRL Viewer plugin.

image

Now I'm using the v0.1 (2019-04-20) of the Arelle iXBRL Viewer plugin.

image

and everything works perfectly!

Thank you so much for your support!


Javier Mora
XBRL Spain
info@xbrl.es

@xbrles xbrles closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants