Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Create a github workflow to run CI #349

Closed
1 of 5 tasks
sagesmith-wf opened this issue Dec 7, 2022 · 2 comments
Closed
1 of 5 tasks

[REQUEST] Create a github workflow to run CI #349

sagesmith-wf opened this issue Dec 7, 2022 · 2 comments
Labels
request New feature or request

Comments

@sagesmith-wf
Copy link
Contributor

sagesmith-wf commented Dec 7, 2022

Description

I have noticed that CI doesn't run for external contributors. After discussion internally, it is recommended that we convert the build and artifact publish to a github workflow setup.

What needs to happen

  • CI is run on each PR via a github actions workflow
  • When a PR is merged, a new release is created
  • The release is pushed to PYPI
  • The release is adds the PYPI artifact to the list
  • The js package is published to NPM

Notes

@austinmatherne-wk
Copy link
Contributor

It's worth pointing out that the existing Python build isn't used internally (npm artifact is used). We need to make sure that's in a working state (and probably just publish the js file to npm).

@sagesmith-wf sagesmith-wf added the request New feature or request label Jan 31, 2023
@sagesmith-wf sagesmith-wf changed the title Create a github workflow to run CI [REQUEST] Create a github workflow to run CI Feb 1, 2023
@sagesmith-wf
Copy link
Contributor Author

The PYPI artifact is still required for arelle, but I will do some work to see how we might handle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants