Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CSS position changing when adding the table export button #369

Closed
sagesmith-wf opened this issue Feb 1, 2023 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@sagesmith-wf
Copy link
Contributor

sagesmith-wf commented Feb 1, 2023

What happened?

The export table button is changing the underlining style of a document. The expectation would be that the export table button would not change the table position at all.

It might have something to do with this

Version

1.1.42

With which browsers are you experiencing the bug?

Chrome

Documents

repro_filing_documents.zip
generated_ixbrl_viewer_from_repro_docs.zip

Screenshots

Untitled1

@sagesmith-wf sagesmith-wf added the bug Something isn't working label Feb 1, 2023
@paulwarren-wk
Copy link
Contributor

I can see why this might occur, but I can't reproduce it with the provided sample. This is what I see. Without viewer:

image

With viewer:

image

@sagesmith-wf
Copy link
Contributor Author

sagesmith-wf commented Feb 2, 2023

I can see why this might occur, but I can't reproduce it with the provided sample.

Sorry, the screenshots are a bit confusing, but not actually paired with the repro doc. It is an example of what could happen, but the actual issue being reported here is the switch to position:relative which could break peoples styles going forward (in the way shown in the screenshot)

@paulwarren-wk
Copy link
Contributor

I can't see a way to fix this using pure CSS, as we want to position the export control relative to the table's top-left, and in order to do that we need it to be position:relative which will unavoidably interfere with positioning a child of the table relative to a parent of the table.

One fix would be to make the export controls children of the body, calculate the position of the table, and place the handles accordingly using JS, but positions would need updating if the document was reflowed due to zoom or change in viewport size.

@sagesmith-wf
Copy link
Contributor Author

It seems reasonable to not fix all of the document style changes. We should probably add the ability to download the original filing though if we aren't going to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants