Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove our dependency on async_extra #9

Closed
brendanlong opened this issue Dec 21, 2017 · 2 comments
Closed

Remove our dependency on async_extra #9

brendanlong opened this issue Dec 21, 2017 · 2 comments

Comments

@brendanlong
Copy link
Contributor

Right now we use Async.Socket from async_extra, which means we have to build all of core. If we could replace that one module with something else, pgx_async would only need core_kernel, core_unix, async_kernel and async_unix.

@brendanlong
Copy link
Contributor Author

Actually maybe it's not Socket. I'll investigate more. I seem to remember there being one thing async_extra or async_extended that we use.

@brendanlong
Copy link
Contributor Author

Oh, it's Tcp.

But looking at it more, it looks like async_extra isn't that bad. async_unix depends on core, so there's not much we can do to remove this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant