Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/v2/quaggans does not return X-Result-Total #15

Closed
sliekens opened this issue Mar 3, 2015 · 4 comments
Closed

/v2/quaggans does not return X-Result-Total #15

sliekens opened this issue Mar 3, 2015 · 4 comments
Labels

Comments

@sliekens
Copy link

sliekens commented Mar 3, 2015

Example request: https://api.guildwars2.com/v2/quaggans?ids=summer,vacation

Actual response headers

HTTP/1.1 200 OK
Content-Type: application/json; charset=utf-8
Content-Encoding: gzip
Content-Language: en
Vary: Accept-Encoding
Server: Microsoft-IIS/7.5
X-Result-Count: 2
Access-Control-Allow-Origin: *
X-Content-Type-Options: nosniff
Date: Tue, 03 Mar 2015 19:12:37 GMT
Content-Length: 107

Expected response headers

HTTP/1.1 200 OK
...
X-Result-Count: 2
X-Result-Total: 35

@lye
Copy link
Contributor

lye commented Mar 3, 2015

X-Page-Total, X-Page-Size and X-Result-Total are only returned when paginating the results, e.g. https://api.guildwars2.com/v2/quaggans?page=0. This should be true for all bulk-expanded endpoints, not just /v2/quaggans.

@sliekens
Copy link
Author

sliekens commented Mar 3, 2015

Is that how it's always been? I'm pretty sure that I remember there being a Total header for bulk requests.

@lye
Copy link
Contributor

lye commented Mar 3, 2015

I may have broken things a couple of weeks ago. Now that I've had some coffee, it makes sense that X-Result-Total would be sent with all bulk-expanded responses.

@lye lye added the Bug label Mar 3, 2015
@lye
Copy link
Contributor

lye commented Mar 30, 2015

The fix for this is now deployed (whoo!)

@lye lye closed this as completed Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants