Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gem, hero point and vista icons to /v2/files #50

Closed
lye opened this issue Jul 1, 2015 · 14 comments
Closed

Add gem, hero point and vista icons to /v2/files #50

lye opened this issue Jul 1, 2015 · 14 comments

Comments

@lye
Copy link
Contributor

lye commented Jul 1, 2015

Forum thread.

@lye lye added the Feature label Jul 1, 2015
@darthmaim
Copy link
Contributor

Can we also get the unused upgrade slot icon? (http://wiki.guildwars2.com/wiki/File:Upgrade_Slot.png)

@codemasher
Copy link
Contributor

While you're at it: please also the icons for wvw-castle/keep/tower/camp in green/blue/red. Currently there's only grey available.
https://render.guildwars2.com/file/015D365A08AAE105287A100AAE04529FDAE14155/102532.png

@MaTTze
Copy link

MaTTze commented Jul 1, 2015

and some kind of profession icons please

@lye
Copy link
Contributor Author

lye commented Jul 1, 2015

unused upgrade slot icon

Yeah, seems reasonable.

also the icons for wvw-castle/keep/tower/camp in green/blue/red

They're actually rendered on-demand for the requested colors; I haven't been able to get RenderSrv actually rendering anything yet (our rendering bits don't work headless), so this one might not happen for awhile.

and some kind of profession icons please

I can dig those up, I think.

@darthmaim
Copy link
Contributor

Since I hope that we get access to achievements soon, I guess the achievement point icon (http://wiki.guildwars2.com/wiki/File:Arenanet_Points.png) wouldn't hurt either.
And all icons from the wallet (gems, karma, spirit shards, laurels, ...)

@lye lye added the ready label Jul 2, 2015
@Palingenesis
Copy link

Lets keep it simple.
Can we have All NCP and POI icons?
After all, we are trying to emulate the map in the game image

@lye lye added needs deploy and removed ready labels Jul 2, 2015
@lye
Copy link
Contributor Author

lye commented Jul 2, 2015

Can we have All NCP and POI icons?

NCP? Not really sure what that is -- also the filled POI icon is also in there already.

@darthmaim
Copy link
Contributor

He means NPC icons. There are quite a few icons on the map ingame that aren't in /v2/files yet, but there is also currently no way to get their positions.

@Palingenesis
Copy link

Opp's yes, my Dyslexy strikes again I meant NPC.
As for POI, I meant that in a general context, any other Icons that Indicate an interesting point not being an NPC.

As for locations:
I was going to ask on the forum, whether not having this info in the floor API is just down to priorities,
obviously resources are all on HoT at the moment.
And if it is OK for people to put the location info here?
It's not a hard thing for me to do, I have currently done the New Lion's Arch and Divinity's Reach.
Once all maps are done by people, ArenaNet could just copy the info and stick it into an API on there servers.

Returning to the Icons:
Is it necessary to have an API for Icons used to identify a point on the map?
Wouldn't it be just simpler to put a copy of each of the icons into a folder on an accessible server, using just the file ID for the name?
Say: https://www.guildwars2.com/map_files/
Then create a web page like the one I made so you can see which one you want and copy it's Url?
http://www.palingenesis.webspace.virginmedia.com/Tim/GW2/Icons/API1_Files.html
After all, in this situation your not looking for an array of data, you just need to know the Url of a particular Icon.

This would also make it easy to use the proposed API/v2/Floors Icon "id" : xxxx .
Once that is sorted.
Haven't understood the need for the signature.
eg.: var icon_Url = "https://www.guildwars2.com/map_files/" + xxxx + ".png".
I guess a simple reference to Icons is needed before v2/floors can be finished?

Edit
I done locations for the City's now and still working on other maps, But I have come up with a list of missing Icons to populate the maps.

Guild Armorer ---
Guild Weaponsmith ---
Guild Promoter ---
Guild Commendation Trader ---
Laurel Murchant ---
Karma Merchant ---
Mystic Forge Merchant ---
Merchant (Purple Stuff) ---
Birthday Vendor ---
Collections Instructor" ---
Try-Key Chest ---
Belcher's Bluff ---
Activity ---
Stairs Up ---
Stairs Down ---
Ramp Up ---
Ramp Down ---
Portal ---
Elevator Up ---
Elevator Down ---
Cave Entrance ---
Armorsmith (Cultural Tier ?) ---
Festival ---
Vista ---
Scout ---

If anyone want to use the coordinates I have done to populate the maps, here is the JS file I've done so far,
MapFloorExtraItems.js

@tivac tivac added the Community label Jul 6, 2015
@RedGlow
Copy link
Contributor

RedGlow commented Sep 18, 2015

Maybe the various currency icons would be useful now too?

@kjintar
Copy link

kjintar commented Sep 18, 2015

Those icons are already included in v2/currencies

@RedGlow
Copy link
Contributor

RedGlow commented Sep 18, 2015

Uh, right! Sorry :)

@lye lye removed the needs deploy label Dec 7, 2015
@darthmaim
Copy link
Contributor

Since I hope that we get access to achievements soon, I guess the achievement point icon (http://wiki.guildwars2.com/wiki/File:Arenanet_Points.png) wouldn't hurt either.

Also mastery point icons.

@lye
Copy link
Contributor Author

lye commented Feb 12, 2016

Pulled the profession/map icons into two separate PRs; going to close out this one since it diverged from the original a bit.

@lye lye closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants