Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST FOR CHANGE] Remove WPS from Tasmota #3221

Closed
arendst opened this issue Jul 14, 2018 · 12 comments
Closed

[REQUEST FOR CHANGE] Remove WPS from Tasmota #3221

arendst opened this issue Jul 14, 2018 · 12 comments

Comments

@arendst
Copy link
Owner

arendst commented Jul 14, 2018 •
edited

The current versions of Tasmota allow for initial wifi configuration using either:

  • serial console
  • Wifi Smartconfig using a mobile phone and the ESP8266 Smartconfig App
  • Wifi Manager providing a local Access Point and a webbrowser
  • Wifi Protected Setup (WPS) using the WPS functionality of a router/switch

Following on to issue #3046 AND the fact that the latest core stage version allows for 4k more heap when WPS is removed from Tasmota (esp8266/Arduino#4889) I hereby ask if anyone is desperate to keep WPS as an initial wifi configuration tool available in Tasmota.

Some may argue that they can never have enough configuration tools but others seem to hate WPS by lack of it's functionality on their routers.

Removing WPS saves 33k(!) code space and in the future saves 4k precious RAM. The current default WPS would then be replaced by Wifi Manager.

So please provide a good reason to keep WPS available within Tasmota.

Rgrds, Theo.
@Jason2866
Copy link
Collaborator

Kick WPS -> 4k more space for features 👍😃

@ascillato
Copy link
Contributor

I also agree. Wifi manager as default. Thanks 👍

arendst added a commit that referenced this issue Jul 14, 2018
@arendst
v6.1.0b - WPS optional
e876b5a 
6.1.0b
 * Add user selection of WPS as define USE_WPS in user_config.h in preparation for core v2.4.2 (#3221)
 * Change default Wifi config option from WPS to Wifi Manager if WPS is disabled (or Wifi Smartconfig if webserver is disabled)
 * Remove WPS from sonoff-minimal saving 33k code space
 * Revert wifi changes implemented in v6.0.0a due to possible bad initial wifi connections
@arendst
Copy link
Owner Author

arendst commented Jul 14, 2018

Best of both world...

Made it optional in v6.1.0b and default OFF saving 33k code and 1k mem with current core versions. +4k mem starting with core v2.4.2 to be released some day...

Thx.

@arendst arendst closed this as completed Jul 14, 2018
@digiblur
Copy link
Contributor

Awesome change! I don't run WPS on anything due to its security risks.

@ascillato
Copy link
Contributor

Theo, as a lot of flash space has been freed up with this, can now be set TasmotaMQTT as default also to eliminate the hungs when mqtt got disconnected? I have been using this TasmotaMQTT driver since you released it and works flawlessly without problems.

@arendst
Copy link
Owner Author

arendst commented Jul 14, 2018

Good idea. I'll start tests too.

@ascillato2 ascillato2 mentioned this issue Jul 14, 2018
Closed
@Jason2866
Copy link
Collaborator

@ascillato
I made difference experiences, with TasmottaMQTT i never reached the "endless" uptimes as before.
Not bad at all, but after 30 - 40 days there is a restart (exception).
I am back, because my wifi and mqtt is very reliable 😃

@digiblur
Copy link
Contributor

@ascillato been using #define MQTT_LIBRARY_TYPE MQTT_TASMOTAMQTT in my user_config since it was added and it has been working great on an array of ESP8266 devices (Sonoff Basic/S20/S31/Dual, NodeMCU, Wemos D1).

@Jason2866
Copy link
Collaborator

@arendst How many space could be freed if wifi config is disabled completly?
I ask because user who are compiling there own version dont need this at all...
Maybe this whole part could be made optional as WPS.

@digiblur
Copy link
Contributor

@Jason2866 I compile my own but I do like the WiFi config in the build so I don't have to hard code any SSIDs, password, etc.

@Jason2866
Copy link
Collaborator

@digiblur That is the reason i asked to make it (if possible and save space) configurable.

arendst added a commit that referenced this issue Jul 15, 2018
@arendst
v6.6.1b - Change wifi options
afdb197 
6.1.1b
 * Add default Wifi Configuration tool as define WIFI_CONFIG_NO_SSID in user_config.h if no SSID is configured (#3224)
 * Add user selection of Wifi Smartconfig as define USE_SMARTCONFIG in user_config.h
 * Add user selection of WPS as define USE_WPS in user_config.h in preparation for core v2.4.2 (#3221)
 * Change default Wifi config option from WPS to Wifi Manager if WPS is disabled
 *   or Wifi Smartconfig if webserver is disabled
 *   or Wifi Serial input if Smartconfig is disabled
 * Remove WPS and SmartConfig from sonoff-minimal saving 56k code space
@Jason2866
Copy link
Collaborator

@arendst THX!! now my v.6.1.1b is only 438.2k

curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 7, 2018
@arendst
v6.1.0b - WPS optional
a411a10 
6.1.0b
 * Add user selection of WPS as define USE_WPS in user_config.h in preparation for core v2.4.2 (arendst#3221)
 * Change default Wifi config option from WPS to Wifi Manager if WPS is disabled (or Wifi Smartconfig if webserver is disabled)
 * Remove WPS from sonoff-minimal saving 33k code space
 * Revert wifi changes implemented in v6.0.0a due to possible bad initial wifi connections
curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 7, 2018
@arendst
v6.6.1b - Change wifi options
87e469e 
6.1.1b
 * Add default Wifi Configuration tool as define WIFI_CONFIG_NO_SSID in user_config.h if no SSID is configured (arendst#3224)
 * Add user selection of Wifi Smartconfig as define USE_SMARTCONFIG in user_config.h
 * Add user selection of WPS as define USE_WPS in user_config.h in preparation for core v2.4.2 (arendst#3221)
 * Change default Wifi config option from WPS to Wifi Manager if WPS is disabled
 *   or Wifi Smartconfig if webserver is disabled
 *   or Wifi Serial input if Smartconfig is disabled
 * Remove WPS and SmartConfig from sonoff-minimal saving 56k code space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@digiblur @arendst @Jason2866 @ascillato