Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Platformio.ini to PIO v4 requirements #6150

Merged
merged 1 commit into from Jul 31, 2019

Conversation

ascillato
Copy link
Contributor

Description:

Changed env_default to default_envs as required by PIO 4 and as to avoid compilation warnings.

Related issue (if applicable): NA

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.3.0, 2.4.2 and 2.5.2
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

Changed env_default to default_envs as required by PIO 4 and as to avoid compilation warnings.
@Jason2866
Copy link
Collaborator

With this change pio <4 will not compile Tasmota anymore
Without the PR pio 4 generates just a warning.

@ascillato
Copy link
Contributor Author

Yes, you are right, but in next version of PIO, env_default will not longer be supported.

And also, as by default, PIO upgrades automatically, most users will have PIO 4.

@arendst
Copy link
Owner

arendst commented Jul 31, 2019

Let's decide to use pio 4 and continue with this change.

@arendst arendst merged commit 4f8e442 into arendst:development Jul 31, 2019
@ascillato ascillato deleted the patch-2 branch July 31, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants