Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some setoptions overridable #11204

Merged
merged 1 commit into from Mar 3, 2021

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Mar 2, 2021

Description:

#11194
#11195

  • my own wish on i2cdriver

Make overridable with:

#define MQTT_BUTTONS          true             // [SetOption73] Detach buttons from relays and send multi-press and hold MQTT messages instead
#define MQTT_SWITCHES          true             // [SetOption114] Detach switches from relays and send MQTT messages instead

#define ZIGBEE_DISTINCT_TOPICS true             // [SetOption89] Enable unique device topic based on Zigbee device ShortAddr

#define I2CDRIVERS_0_31        0xAAAAAAAA          // Enable I2CDriver0  to I2CDriver31
#define I2CDRIVERS_32_63       0x55555555          // Enable I2CDriver32 to I2CDriver63
#define I2CDRIVERS_64_95       0xA5A5A5A5          // Enable I2CDriver64 to I2CDriver95

Should have very limited impact on code size when override is used. No impact if not used ( |= false is optimized to no-op).

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@nagyrobi
Copy link
Contributor

nagyrobi commented Mar 3, 2021

Thanks, man!

@arendst arendst merged commit 5f16952 into arendst:development Mar 3, 2021
@barbudor barbudor deleted the some_setoptions_override branch March 3, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants