Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prometheus metrics parse error on DS18x20 and align other metrics #11931

Merged
merged 2 commits into from Apr 28, 2021
Merged

Fix Prometheus metrics parse error on DS18x20 and align other metrics #11931

merged 2 commits into from Apr 28, 2021

Conversation

twollweber
Copy link

@twollweber twollweber commented Apr 28, 2021 •
edited by ascillato2

Description:

Fix Prometheus metrics parse error on DS18x20
Align tasmotaglobal metrics for Prometheus to other metrics' syntax

Related issue (if applicable): fixes #11930, #11933

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@ascillato2 ascillato2 changed the title Fix for issue #11930 Fix Prometheus metrics parse error on DS18x20 Apr 28, 2021
@twollweber
Fix arendst#11933
0558430 
Fix Align tasmotaglobal metrics for Prometheus to other metrics' syntax
@twollweber twollweber mentioned this pull request Apr 28, 2021
Closed
14 tasks
@ascillato2 ascillato2 self-requested a review April 28, 2021 20:57
@ascillato2 ascillato2 changed the title Fix Prometheus metrics parse error on DS18x20 Fix Prometheus metrics parse error on DS18x20 and align other metrics Apr 28, 2021
@ascillato2 ascillato2 linked an issue Apr 28, 2021 that may be closed by this pull request
Align tasmotaglobal metrics for Prometheus to other metrics' syntax #11933
Closed
14 tasks
@ascillato2
Copy link
Collaborator

Thanks

@ascillato2 ascillato2 merged commit 70d222a into arendst:development Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascillato2 ascillato2 ascillato2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@twollweber @ascillato2