Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topic must differ from mqttclient #14019

Merged

Conversation

barbudor
Copy link
Contributor

Description:

Removing an old constraint that Topic/ButtonTopic/SwitchTopic/GroupTopic should be different from MqttClient as the reasons for that are no more present.
Still enforce that GroupTopic should be different from Topic to avoid double subscription.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.1.1
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit bc83f15 into arendst:development Dec 12, 2021
@arendst
Copy link
Owner

arendst commented Dec 12, 2021

Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants