Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 Compile error when I2S_AUDIO is enabled #14095

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

Meek-HA
Copy link

@Meek-HA Meek-HA commented Dec 18, 2021

Solves the compiling error with env:tasmota32 when I2s Audio is enabled:
#ifndef USE_I2S_AUDIO
#define USE_I2S_AUDIO
#endif

#ifdef USE_I2S_EXTERNAL_DAC
#undef USE_I2S_EXTERNAL_DAC
#endif

#ifndef USE_I2S_NO_DAC
#define USE_I2S_NO_DAC
#endif

Resolving the following compiling error:
tasmota/xdrv_42_i2s_audio.ino:326:11: error: invalid conversion from 'AudioOutputI2S*' to 'AudioOutputI2SNoDAC*' [-fpermissive]

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.1.1
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Solves the compiling error with env:tasmota32 when I2s Audio is enabled:
#ifndef USE_I2S_AUDIO
#define USE_I2S_AUDIO
#endif

#ifdef USE_I2S_EXTERNAL_DAC
#undef USE_I2S_EXTERNAL_DAC
#endif

#ifndef USE_I2S_NO_DAC
#define USE_I2S_NO_DAC
#endif

Resolving the following compiling error:
tasmota/xdrv_42_i2s_audio.ino:326:11: error: invalid conversion from 'AudioOutputI2S*' to 'AudioOutputI2SNoDAC*' [-fpermissive]
@Meek-HA Meek-HA mentioned this pull request Dec 18, 2021
6 tasks
@arendst arendst merged commit 847203c into arendst:development Dec 20, 2021
@Meek-HA Meek-HA deleted the patch-2 branch December 21, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants